Re: 2.2.3-pre3 - `make modules_install' doesn't.

Zygo Blaxell (uixjjji1@umail.furryterror.org)
9 Mar 1999 12:30:52 -0500

In article <Pine.LNX.4.05.9903082233120.8606-100000@cyberelk.elk.co.uk>,
Tim Waugh <tim@cyberelk.demon.co.uk> wrote:
>On 8 Mar 1999, Zygo Blaxell wrote:
>> I just built a 2.2.3-pre3 on an i386, a small kernel with lots of modules.
>> Here's a list of all the modules that were _not_ installed by
>> 'make config && make dep && make bzImage modules && make modules_install':
>>[names of 100+ modules deleted]

D'oh! Patch at bottom of this message.

Here's the cause of the problem:

root@japoro:~/linux/2.2.3-pre3/linux# type ls
ls is a function
ls ()
{
command ls -FlAgs "$@"
}

Non-working case (62 modules in misc aren't installed):

root@japoro:~/linux/2.2.3-pre3/linux# make modules_install
Installing modules under /lib/modules/2.2.3/block
Installing modules under /lib/modules/2.2.3/net
Installing modules under /lib/modules/2.2.3/ipv4
Installing modules under /lib/modules/2.2.3/scsi
Installing modules under /lib/modules/2.2.3/fs
Installing modules under /lib/modules/2.2.3/fs
Installing modules under /lib/modules/2.2.3/cdrom
Installing modules under /lib/modules/2.2.3/video
root@japoro:~/linux/2.2.3-pre3/linux# cd modules
root@japoro:~/linux/2.2.3-pre3/linux/modules# for file in *.o; do [ -f /lib/modules/2.2.3/*/$file ] || cp -v $file /lib/modules/2.2.3/misc; done 2>&1 | wc -l
62

Working case (0 modules not properly installed):

root@japoro:~/linux/2.2.3-pre3/linux/modules# cd ..
root@japoro:~/linux/2.2.3-pre3/linux# (unset ls; make modules_install)
Installing modules under /lib/modules/2.2.3/block
Installing modules under /lib/modules/2.2.3/net
Installing modules under /lib/modules/2.2.3/ipv4
Installing modules under /lib/modules/2.2.3/scsi
Installing modules under /lib/modules/2.2.3/fs
Installing modules under /lib/modules/2.2.3/fs
Installing modules under /lib/modules/2.2.3/cdrom
Installing modules under /lib/modules/2.2.3/video
Installing modules under /lib/modules/2.2.3/misc
root@japoro:~/linux/2.2.3-pre3/linux# cd modules
root@japoro:~/linux/2.2.3-pre3/linux/modules# for file in *.o; do [ -f /lib/modules/2.2.3/*/$file ] || cp -v $file /lib/modules/2.2.3/misc; done 2>&1 | wc -l
0
root@japoro:~/linux/2.2.3-pre3/linux/modules#

Patch that causes 'make modules_install' to avoid using 'ls':

--- linux/Makefile~ Tue Mar 9 12:13:21 1999
+++ linux/Makefile Tue Mar 9 12:14:11 1999
@@ -323,7 +323,7 @@
if [ -f FC4_MODULES ]; then inst_mod FC4_MODULES fc4; fi; \
if [ -f IRDA_MODULES ]; then inst_mod IRDA_MODULES net; fi; \
\
- ls *.o > $$MODLIB/.allmods; \
+ for f in *.o; do [ -r $$f ] && echo $$f; done > $$MODLIB/.allmods; \
echo $$MODULES | tr ' ' '\n' | sort | comm -23 $$MODLIB/.allmods - > $$MODLIB/.misc; \
if [ -s $$MODLIB/.misc ]; then inst_mod $$MODLIB/.misc misc; fi; \
rm -f $$MODLIB/.misc $$MODLIB/.allmods; \

-- 
Zygo Blaxell, Linux Engineer, Corel Corporation, zygob@corel.ca (work),
zblaxell@furryterror.org (play).  It's my opinion, I tell you! Mine! All MINE!
Size of 'diff -Nurw [...] winehq corel' as of Tue Mar  9 12:14:00 EST 1999
Lines/files:  In 1 / 0, Out 5773 / 59, Both 5773 / 59


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/