Re: TTY_FLIPBUF_SIZE too low causing dataloss on too fast serial lines?

Alan Cox (alan@lxorguk.ukuu.org.uk)
Thu, 27 May 1999 20:44:51 +0100 (BST)


> One question though is how is your irda driver grabbing the characters?
> Is it grabbing them all at interrupt time, or is it polling like many of
> the high-speed intelligent serial boards? If it's polling, you *don't*
> to use the flip buffers; instead, just throw it onto a local buffer and
> just call the line discpline directly. (See the Rocketport driver for
> an example of this). Remember, you don't *have* to use the flip buffer
> abstraction; it's a service which the tty layer provides to reduce the
> amount of time spent in the interrupt driver, but you can bypass it if
> you wish.

Question: Since tty_flip_buffer_push just shoves the request onto tq_timer,
is it valid to use a private tty_flip_buffer_push that checks if the buffer
is looking close to full and pushes it onto tq_immed then marks that queue
to be run on the irq return (remembering we have no fast irq paths in 2.2
any more)

In fact, couldnt tty_flip_buffer_push do this ?

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/