Re: pre-2.3.4..

Alexander Viro (viro@math.psu.edu)
Sat, 29 May 1999 15:13:42 -0400 (EDT)


On Thu, 27 May 1999, Chuck Lever wrote:

> On Tue, 25 May 1999, Linus Torvalds wrote:
> > There's a pre-2.3.4-1 out there in "testing" on ftp.kernel.org, which has
> > the new scalable network code (well, the first cut of it, anyway). It also
> > updates ISDN and PPC to newer versions. Please test it out and give
> > feedback..
>
> linus-
>
> attached is a patch that removes the global kernel lock from brk() and
> when doing anonymous mmap(). it also reorganizes the locking logic in
> handle_pte_fault() to reduce the amount of time spent with the lock held
> needlessly. the handle_pte_fault() change may be more dangerous than the
> brk() and mmap() changes. it may also be unnecessary with the upcoming
> parallelized page cache.

Chuck, it's unsafe. do_munmap() called from sys_brk() (or from do_mmap()
for that matter) may lead to ->f_count changes, which is *not* the thing
you want to do without big lock.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/