Re: Linux 2.2.* remote exploit fix
Ian Eure (ieure@crosssound.narrows.com)
Tue, 01 Jun 1999 18:20:10 -0700
Alan Cox wrote:
>
> This is a *provisional* fix. It seems to work, it seem to be the explanation
>
> Alan
>
> --- ../linux.vanilla/net/ipv4/ip_options.c Wed May 12 16:49:38 1999
> +++ net/ipv4/ip_options.c Tue Jun 1 22:11:46 1999
> @@ -452,7 +452,6 @@
> error:
> if (skb) {
> icmp_send(skb, ICMP_PARAMETERPROB, 0, htonl((pp_ptr-iph)<<24));
> - kfree_skb(skb);
> }
> return -EINVAL;
> }
>
I'm not very familiar with the kernel code, but won't this introduce a
memory leak?
--
.-------------------------------------------------------------------------
| Ian Eure <ieure@crosssound.narrows.com>
| Network Administrator, Cross Sound Appraisal Company
|
| "Believe it or not, there's more to being a sysadmin than rabid
| technophilia." --Annalee Newitz, "Invisible Heroes"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/