2.2.9-ac1..3 breaks sound

Michael Surenbrock (misu@basis.gun.de)
Mon, 7 Jun 1999 11:47:31 GMT


MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi!

I just wanted to tell that 2.2.9-ac1,2,3 breaks sound in quake, which
isn't very nice. :-)

There's a small klick twice a second depending on the
selected sound-frequency. So I had a look in the patches and found this
bit of code beeing resposible for the damage:

-------------------------------------------------------------------------

In linux.ac/drivers/sound/dmabuf.c:

@@ -109,7 +109,7 @@
dmap->raw_buf = start_addr;
dmap->raw_buf_phys = virt_to_bus(start_addr);

- for (i = MAP_NR(start_addr); i <= MAP_NR(end_addr); i++)
+ for (i = MAP_NR(start_addr); i < MAP_NR(end_addr); i++)
set_bit(PG_reserved, &mem_map[i].flags);;
return 0;
}
@@ -128,7 +128,7 @@
start_addr = (unsigned long) dmap->raw_buf;
end_addr = start_addr + dmap->buffsize;

- for (i = MAP_NR(start_addr); i <= MAP_NR(end_addr); i++)
+ for (i = MAP_NR(start_addr); i < MAP_NR(end_addr); i++)
clear_bit(PG_reserved, &mem_map[i].flags);;

free_pages((unsigned long) dmap->raw_buf, sz);

------------------------------------------------------------------------

So, is it wright to shorten the adress-range by one or is quake(glquake)
misbehaving? :-)

miSu

-- 

/ Michael Surenbrock / m.surenbrock@infocity.de / misu@basis.gun.de

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/