Re: NFS bug in 2.2.9-ac? found (was Re: Kernel Panic: 2.2.9-ac1)

Thierry Danis (danis@sagem.fr)
Mon, 7 Jun 1999 20:12:52 +0200


On Mon, Jun 07, 1999 at 05:37:30PM +0200, Trond Myklebust wrote:
> Theo Van Dinter <felicity@kluge.net> writes:
>
> > On Friday afternoon, I upgraded the news server from 2.2.4-ac? to 2.2.9-ac1.
> > By Saturday morning, the news server was no more.
> >
> > News server HW: Single PII 266 w/ 128Mb RAM. 2x3Com 3x590 NICs. NCR53x875
> > based SCSI adapter.
> >
> > When I came in on Monday morning, I wrote down the panic info on the console
> > and tried running a ksymoops on it. Here's what it found:
> >
> > Copying default arch from ksymoops, bfd_arch=8 bfd_mach=0
> >
> > >>EIP; c011f153 <__free_page+97/d0>
> > Trace; c0141ec9 <nfs_updatepage+251/2fc>
>
>
> Ah. I see what's happened. It looks as though somebody has added the
> statement 'page_cache_release(page);' to the definition of
> nfs_unlock_page in nfs_cluster.h in the 2.2.9-ac series. I can't find
> it in my tree, so I think I can claim innocence on this one...
>
> Could people who've experienced problems with NFS under the 2.2.9-ac
> series, please apply the following patch.
>
> Cheers,
> Trond
>
> --- linux-2.2.9-ac3/include/linux/nfs_cluster.h-orig Mon Jun 7 17:29:29 1999
> +++ linux-2.2.9-ac3/include/linux/nfs_cluster.h Mon Jun 7 17:33:17 1999
> @@ -149,7 +149,6 @@
> {
> clear_bit(PG_locked, &page->flags);
> wake_up(&page->wait);
> - page_cache_release(page);
> }
> #endif
>

Thank's Trond !

I just tried it, and no crash ! (it used to crash within a matter
of seconds).

More than that, 2.2.9-ac1 behaves during NFS reading as well as
2.2.6/2.2.7 :

IOZONE performance measurements:
6126649 bytes/second for writing the file
4501292 bytes/second for reading the file

2.2.9 was really bad during reading and loads the knfsd server
much too much.

A+,

-- 
	Thierry Danis
	Poste : 53 53	danis@spmo.sagem.fr

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/