Re: [PATCH] 2.2.10-pre4 IDE config problems

Andrzej Krzysztofowicz (ankry@green.mif.pg.gda.pl)
Tue, 6 Jul 1999 19:11:17 +0200 (EEST)


> Yep, I know.
[...]
> I respect you changes and suggestions; however, I differ with the out come.
>
> The moving of CONFIG_BLK_DEV_IDEDMA_PCI and CONFIG_IDEDMA_AUTO will
> most likely break other archs in the kernel. I spent five (5) days thing

They should not. Even if "define_bool foo y" repeats a few times it
does not hurt (unlike other config functions which break menuconfig/xconfig
when repeated).
If you want to avoid it, you can use a hack like:

: if [ "$foo" != "y" ]; then
: define_bool foo y

Initial "define_bool foo n" should be, IMO, replaced by "undef foo",
however, *after* menuconfig/xconfig are fixed to handle "undef" command
properly (I've sent a patch fixing it to Michael <mec@shout.net> a month
or two ago) ...

Please take these comments into account when creating the final version of
IDE configuration.

> why is this needed. The Config.in only relfects the ifdefs in the code.
> This is a change that Linus started and I finished.
>
> On Tue, 6 Jul 1999, Andrzej Krzysztofowicz wrote:
>
> > Hi,
> > I noticed that current (2.3.10-pre4) drivers/block/Config.in handling
> > of some IDE-related options does not properly handle old .config values
> > (i.e. uses old options when they should be ignored).
> > The simple example is (for i386 arch.): to disable CONFIG_PCI with following
> > options in old .config enabled:

Regards
Andrzej

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/