On Wed, 14 Jul 1999 14:52:46 -0700, Richard Henderson <rth@twiddle.net>
said:
> On Wed, Jul 14, 1999 at 06:48:43PM +0100, Stephen C. Tweedie wrote:
>> +{
>> + update_vm_cache_conditional(inode, pos, buf, count, 0);
>> +}
> `0' isn't the best value to have chosen. Better something
> like `-1' that can't be mapped in userspace.
0 is fine. The case we are trying to detect is an alias between the
source buffer and the page cache, which is a kernel VA. 0 can never be
mistaken for a valid kernel address, so it's just fine. Any user
address would be OK --- it's only with kernel addresses that we'd have
to be careful.
--Stephen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/