Re: PATCHES (unused code/vars...) for 2.3.18ac8

Alan Cox (alan@lxorguk.ukuu.org.uk)
Fri, 24 Sep 1999 12:42:35 +0100 (BST)


> return;
> - /*
> - * Allocate a new page in virtual address space,
> - * move the IDT into it and write protect this page.

Rejected. Remove the return - its a debugging temporary.

> p = Cx486S_name[0];
> break;
> - break;

Fixed properly in -ac

> -asmlinkage long sys_sched_rr_get_interval(pid_t pid, struct timespec *interval)
> +asmlinkage long sys_sched_rr_get_interval(struct timespec *interval)
> {

This is a syscall you cant go around deleting arguments

> +++ drivers/net/8390.c Fri Sep 24 01:59:19 1999
> @@ -149,7 +149,6 @@
> int ei_open(struct net_device *dev)
> {
> unsigned long flags;
> - struct ei_device *ei_local = (struct ei_device *) dev->priv;
>
> /* This can't happen unless somebody forgot to call ethdev_init(). */

This variable IS used.

>
> -int apm_get_info(char *buf, char **start, off_t fpos, int length, int dummy)
> +int apm_get_info(char *buf)

These are parameters passed by the calling function

> -static inline void flush_tlb_range(struct mm_struct *mm,
> - unsigned long start, unsigned long end)
> +static inline void flush_tlb_range(struct mm_struct *mm)

These are values used on other platforms

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/