Missed that, I skipped straight to the code :)
I think there is still room for improvement. '-march=k6' should be a
win on all K6's. Also, CONFIG_X86_USE_3DNOW is new and not necessarily
mature.
For those reasons I think that CONFIG_X86_USE_3DNOW should be an option,
not a feature auto-selected by config.in. That will allow users to
choose whether or not they want to use the new MMX routines.
if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
if [ "$CONFIG_MK6" = "y" -o "$CONFIG_MK7" = "y" ]; then
bool '3Dnow/MMX support routines' CONFIG_X86_USE_3DNOW
fi
fi
Take this with a grain of salt, Alan ignored a similar patchlet from me.
> BTW.
> in the file arch/i386/lib/usercopy.c there is a "#ifdef
> CONFIG_X86_USE_3DNOW_AND_WORKS"
> which enables some mmx routines. I cannot find any other references to
> "CONFIG_X86_USE_3DNOW_AND_WORKS".
> Do you have an idea why this variable is used or is it just a typo?
> Anyway... I've changed it to "#ifdef CONFIG_X86_USE_3DNOW", as you can
> se below.
This looked to me like the semantic equivalent of '#if 0'. I would not
remove "_AND_WORKS" without heavy testing on both K6 and K7.
> Also:
> To whom should I send this patch, for it to be merged into the kernel
> tree?
Until Linus gets back from vacation, Alan Cox <alan@redhat.com> is
temporarily Head Penguin.
Regards,
Jeff
-- Custom driver development | Never worry about theory as long Open source programming | as the machinery does what it's | supposed to do. -- R. A. Heinlein- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/