The ptrace patch in .22

Jeff Dike (jdike@karaya.com)
Wed, 20 Oct 1999 00:55:44 -0400

Linus, I hate to be a pain about ptrace, but in the following .22 change

--- v2.3.21/linux/arch/i386/kernel/ptrace.c Sun Jul 11 09:11:46 1999
+++ linux/arch/i386/kernel/ptrace.c Tue Oct 12 10:05:53 1999
@@ -71,8 +71,6 @@
unsigned long regno, unsigned long value)
{
switch (regno >> 2) {
- case ORIG_EAX:
- return -EIO;
case FS:
if (value && (value & 3) != 3)
return -EIO;

I think there ought to be a check against NR_syscalls like this: case
ORIG_EAX:
if (value >= NR_syscalls)
return -EIO;

Otherwise, bogus ptrace calls are going to apparently succeed when they should
return error.

Was there a particular reason you did things this way?

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/