[PATCH] four warnings and a patch

Dennis Hou (smilax@mindmeld.yi.org)
Thu, 28 Oct 1999 16:39:37 -0400 (EDT)

This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

---741981929-1514538586-941143177=:29754
Content-Type: TEXT/PLAIN; charset=US-ASCII

My recent attempt at compiling a vanilla 2.3.24 gave the following
warnings:

sched.c:124: warning: alignment of `aligned_data' is greater than maximum
object file alignment
irq.c:77: warning: alignment of `irq_desc' is greater than maximum object
file alignment
init_task.c:33: warning: alignment of `init_tss' is greater than maximum
object file alignment

I'm quite sure that they are related to NR_CPUS (hence they cause problems
for UP users) but no serious damage occurs that I am aware of. Removing
__cacheline_aligned fixes the problem, but I'm not sure if it will affect
SMP systems.

8390.c:1092: warning: unused variable `ei_local'
The patch removes this line.

dir.c:689: warning: `show_dentry' defined but not used
I'm assuming it is used for debugging purposes (it's in the NFS code, but
unused as far as I can tell.) Maybe it can be removed sometime soon...?

dquot.c:477: warning: `count' might be used uninitialized in this function
I have no idea what this is for. It's not initialized, but there is an if
(count) later on. It never gets modified; maybe it was mixed up with
dquot->dq_count.

Can somebody more knowledgable about the above please get these warnings
out? After all, perfect compilation is the first step to a Good kernel.

---741981929-1514538586-941143177=:29754
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="small.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.3.96.991028163937.29754B@mindmeld.yi.org>
Content-Description:

LS0tIGxpbnV4LW9sZC9kcml2ZXJzL25ldC84MzkwLmMJU2F0IE9jdCAxNiAx
MzoxOTowNCAxOTk5DQorKysgbGludXgvZHJpdmVycy9uZXQvODM5MC5jCVNh
dCBPY3QgMTYgMTM6MTk6NDIgMTk5OQ0KQEAgLTEwODksNyArMTA4OSw2IEBA
DQogCQkJCQkJCQlpbnQgc3RhcnRfcGFnZSkNCiB7DQogCWxvbmcgZTgzOTBf
YmFzZSA9IGRldi0+YmFzZV9hZGRyOw0KLSAJc3RydWN0IGVpX2RldmljZSAq
ZWlfbG9jYWwgPSAoc3RydWN0IGVpX2RldmljZSAqKSBkZXYtPnByaXY7DQog
ICAgDQogCW91dGJfcChFODM5MF9OT0RNQStFODM5MF9QQUdFMCwgZTgzOTBf
YmFzZStFODM5MF9DTUQpOw0KICAgICANCg==
---741981929-1514538586-941143177=:29754--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/