Re: [PATCH] fbmem.c on 2.3.25 (had trouble with the other one)

Scott Marlowe (kernel@kvack.org)
Wed, 3 Nov 1999 14:19:04 -0500 (EST)


On Wed, 3 Nov 1999, Mordechai T. Abzug wrote:

> - if (vma->vm_offset >= len) {
> + if (vma->vm_pgoff << PAGE_SHIFT >= len) {

This is better, but still wrong. What happens when shifting vm_pgoff
overflows the unsigned long? This will be possible -- it's why the
changes were done in the first place.

-ben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/