On Sat, 18 Mar 2000, Andrew Morton wrote:
> > > + KASSERT(spin_is_locked(&kernel_flag));
> >
> > this is more readable i believe:
> >
> > if (!spin_is_locked(&kernel_flag))
> > BUG();
>
> Yes. But your assertion needs to be physically removed from production
> code, whereas the presence/absence of KASSERT can be centrally
> controlled.
we want to keep 'permanent debugging code' out of the main kernel, as much
as possible. There is no problem in having separate debugging patches
(such as IKD, which is a much more capable debugging tool than plain
asserts). Permanent debugging code pollutes the kernel over time and
degrades readability and maintainability.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:23 EST