Re: [one more PATCH] Re: Old HD driver does not compile in 2.3.99pre9-2

From: Andrzej Krzysztofowicz (ankry@green.mif.pg.gda.pl)
Date: Mon May 22 2000 - 10:48:24 EST

> Now I expect from you comments telling us whether these fixes suffice,
> or that further work is required. Instead you mutter about 6 versus 4 -
> my source tree is not the same as yours, and my code is correct for both.
> Let us fix bugs instead of quibbling.

Sorry, I have also found the problems and sent their description to the list.
I forgot to forward that to you.

I thought previously (basing on the code) that ide_xlate_1024() was intended
to work with hd.c also...

> Yes. I've tested and found the guilties.
>
> First: LBA geometry in BIOS; using hd= parameter is necessary, but it didn't
> work.
> Second: in non-PCI case ide.c detection code probes also for ide0 ...
>
> Fixed, and a patch sent to Andre.

The second change it needs to work is:
***********************************************************
--- ide.c.old Mon May 22 17:39:34 2000
+++ ide.c Mon May 22 17:41:48 2000
@@ -2141,7 +2141,10 @@
         memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->hw.io_ports));
         hwif->irq = hw->irq;
         hwif->noprobe = 0;
-
+#ifdef CONFIG_BLK_DEV_HD
+ if (hwif->io_ports[IDE_DATA_OFFSET] == HD_DATA)
+ hwif->noprobe = 1; /* may be overridden by ide_setup() */
+#endif /* CONFIG_BLK_DEV_HD */
         if (!initializing) {
                 ide_probe_module();
 #ifdef CONFIG_PROC_FS
*************************************************************** 

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:22 EST