Re: tulip broken in 2.4.0-t1-ac6/7

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat Jun 03 2000 - 14:17:23 EST


Meelis Roos wrote:
>
> AC> 2.4.0-test1-ac6
> AC> o Tulip updates (Jeff Garzik)
>
> This breaks my 21143.
> NETDEV WATCHDOG: eth0: transmit timed out
> is all I get. de4x5 works. The card is in 100mbit mode, half-duplex.
> ac4 worked OK. ac7 was the next I tried and it doesn't work. ac6 touched
> tulip so it's probably the cause.

Here is a fix, which should be in ac8 when it is released...

-- 
Jeff Garzik              | Liberty is always dangerous, but
Building 1024            | it is the safest thing we have.
MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick

Index: drivers/net/tulip/eeprom.c =================================================================== RCS file: /g/cvslan/linux_2_3/drivers/net/tulip/Attic/eeprom.c,v retrieving revision 1.1.1.6 retrieving revision 1.1.1.6.4.1 diff -u -r1.1.1.6 -r1.1.1.6.4.1 --- drivers/net/tulip/eeprom.c 2000/05/30 23:29:49 1.1.1.6 +++ drivers/net/tulip/eeprom.c 2000/05/31 14:10:21 1.1.1.6.4.1 @@ -162,9 +162,12 @@ if (tp->flags & CSR12_IN_SROM) csr12dir = *p++; count = *p++; + /* there is no phy information, don't even try to build mtable */ - if (count == 0) + if (count == 0) { + DPRINTK("no phy info, aborting mtable build\n"); return; + } mtable = (struct mediatable *) kmalloc(sizeof(struct mediatable) + count*sizeof(struct medialeaf), Index: drivers/net/tulip/tulip_core.c =================================================================== RCS file: /g/cvslan/linux_2_3/drivers/net/tulip/Attic/tulip_core.c,v retrieving revision 1.1.1.13 retrieving revision 1.1.1.13.4.2 diff -u -r1.1.1.13 -r1.1.1.13.4.2 --- drivers/net/tulip/tulip_core.c 2000/05/30 23:29:50 1.1.1.13 +++ drivers/net/tulip/tulip_core.c 2000/05/31 21:47:11 1.1.1.13.4.2 @@ -19,7 +19,7 @@ */ -static const char version[] = "Linux Tulip driver version 0.9.5 (May 30, 2000)\n"; +static const char version[] = "Linux Tulip driver version 0.9.6 (May 31, 2000)\n"; #include <linux/module.h> #include "tulip.h" @@ -125,7 +125,7 @@ { "Digital DS21140 Tulip", 128, 0x0001ebef, HAS_MII | HAS_MEDIA_TABLE | CSR12_IN_SROM, tulip_timer }, { "Digital DS21143 Tulip", 128, 0x0801fbff, - HAS_MII | HAS_MEDIA_TABLE | HAS_NWAY + HAS_MII | HAS_MEDIA_TABLE | ALWAYS_CHECK_MII | HAS_ACPI | HAS_NWAY | HAS_INTR_MITIGATION, t21142_timer }, { "Lite-On 82c168 PNIC", 256, 0x0001ebef, HAS_MII | HAS_PNICNWAY, pnic_timer },

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jun 07 2000 - 21:00:17 EST