Re: [PATCH][RFC] check fib6_lookup_1 return in fib6_lookup_1

From: David S. Miller (davem@redhat.com)
Date: Mon Sep 11 2000 - 19:27:56 EST

   Date: Mon, 11 Sep 2000 18:34:22 -0300
   From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>

           fib6_lookup_1 can return NULL, please consider applying.

(Note that CONFIG_IPV6_SUBTREES is never turned on :-)

I think more to the intent is to just continue the main search logic
if it returns NULL at this spot, and hence is the change I have
put into my sources.

--- net/ipv6/ip6_fib.c.~1~ Wed May 3 00:08:47 2000
+++ net/ipv6/ip6_fib.c Mon Sep 11 17:26:03 2000
@@ -638,10 +638,8 @@
                         if (narg->addr) {
                                 st = fib6_lookup_1(fn->subtree, narg);
 
- if (!(st->fn_flags & RTN_ROOT))
- {
+ if (st && !(st->fn_flags & RTN_ROOT))
                                         return st;
- }
                         }
                 }
 #endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Sep 15 2000 - 21:00:16 EST