Re: can we drop early_serial_setup()?

From: Mark A. Greer (
Date: Mon Sep 23 2002 - 17:44:14 EST


Sorry for the delay, we've had email problems most of last week.

Yes, we can get rid of the early_serial_setup() in ev64260_setup.c, no
problem there. I'm very busy on some other things right now but I'll try
to get to that soon. If you can't wait, go ahead and make the change and
I will test it for you.



David Mosberger wrote:

> The early_serial_setup() routine was broken during the big serial > clean up that happened a while ago. I fixed this problem for ia64 by > introducing a new routine called early_register_port() (see below). > It serves the same purpose as early_serial_setup(), with the only > difference being that the argument passed to it is now a "uart_port" > structure (instead of a "serial_struct"). Russell King suggested to > get rid of early_serial_setup() alltogether, since it is broken anyhow > and serves no purpose anymore. However, as far as I can tell, there > are two places left which use this routine: > > arch/ia64/sn/kernel/setup.c > arch/ppc/platforms/ev64260_setup.c > > It's should be easy to convert these files to early_register_port(), > but since I can't test the platform's in question (PPC and SGI SN > machine), I'd like to know whether it's OK to drop > early_serial_setup() now. If someone wants some hints on how to do > the conversion, let me know (sample code is in 8250_hcdp.c). > > Thanks, > > --david > > int __init early_register_port (struct uart_port *port) > { > if (port->line >= ARRAY_SIZE(serial8250_ports)) > return -ENODEV; > > serial8250_isa_init_ports(); /* force ISA defaults */ > serial8250_ports[port->line].port = *port; > serial8250_ports[port->line].port.ops = &serial8250_pops; > return 0; > }

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to More majordomo info at Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:40 EST