On Wed, Mar 26, 2003 at 05:27:23PM +0100, Martin Schwidefsky wrote:
>
> > > + typeof (chsc_area_ssd.response_block)
> > > + *ssd_res = &chsc_area_ssd.response_block;
> >
> > Yikes! Please use the actual type here instead of typeof()
> Trouble is that response_block is an anonymous structure. There
> is not type...
Then add one.
> > What about using GFP_KERNEL | __GFP_DMA instead? This makes it
> > more clear that it's just a qualifier.
> Hmm, GFP_DMA and __GFP_DMA are equivalent. I don't quite see your
> point here.
The __GFP flags are modifiers, the GFP_ flags usually can be used standalone -
with the exception of GFP_DMA which shouldn't exist.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:25 EST