Re: [PATCH] Re: VIA PCI IRQ router bug fix

From: Davide Libenzi (davidel@xmailserver.org)
Date: Fri Jul 04 2003 - 10:12:50 EST


On Fri, 4 Jul 2003, Arjan van de Ven wrote:

>
> >
> > static int pirq_via_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
> > {
> > - write_config_nybble(router, 0x55, pirq, irq);
> > + write_config_nybble(router, 0x55, pirq == 4 ? 5 : pirq, irq);
> > return 1;
> > }
>
>
> you missed the
> > + return (x >> 4);
> in the original patch... so your code is NOT identical.

It's ok :

nybble(0x57, 1) == nybble(0x55, 5)

- Davide

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 07 2003 - 22:00:23 EST