Re: 2.4.22pre7aa1: unresolved in sk98lin

From: Martin Schlemmer
Date: Tue Sep 02 2003 - 12:10:08 EST


On Tue, 2003-09-02 at 09:20, Marc-Christian Petersen wrote:
> On Tuesday 02 September 2003 01:46, Andrea Arcangeli wrote:
>
> Hi Andrea,
>
> > > depmod: *** Unresolved symbols in
> > > /lib/modules/2.4.22-pre7-aa1/kernel/drivers/net/sk98lin/sk98lin.o
> > > depmod: __udivdi3
> > There are several functions triggering this problem, and it's a mainline
> > 2.4 problem (I don't see anything specific to my tree).
> > I'm CCing the authors of the driver, is there a new version or are we the
> > first triggering it? I can fix it myself but I'd prefer to avoid any
> > duplication since it's not a one liner.
>
> the problem is _was_ the sk98lin driver, but this problem is gone for a very
> long time now. 2.4.23-pre* will get an update in the next days with sk98lin
> v6.17 (current 6.02 is in mainline) and the problem is gone with it.
>
> Or at least, I don't get the unresolved symbols problem with it ;)
>

Below is the patch that was used for 2.5 - might be the same
thing. I don't know who posted it originally though, Andrew
might be able to help out with that as he posted it when I
tried to port the drivers back then ...

--------------------------
diff -puN drivers/net/sk98lin/h/skgepnm2.h~sk98-build-fix
drivers/net/sk98lin/h/skgepnm2.h
--- 25/drivers/net/sk98lin/h/skgepnm2.h~sk98-build-fix Thu Mar 6
16:18:07 2003
+++ 25-akpm/drivers/net/sk98lin/h/skgepnm2.h Thu Mar 6 16:18:07 2003
@@ -341,7 +341,7 @@ typedef struct s_PnmiStatAddr {
#if SK_TICKS_PER_SEC == 100
#define SK_PNMI_HUNDREDS_SEC(t) (t)
#else
-#define SK_PNMI_HUNDREDS_SEC(t) (((t) * 100) /
(SK_TICKS_PER_SEC))
+#define SK_PNMI_HUNDREDS_SEC(t) ((((long)t) * 100) /
(SK_TICKS_PER_SEC))
#endif

/*


--
Martin Schlemmer


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/