Re: PATCH 1/2: Make gotoxy & siblings use unsigned variables

[Nigel Cunningham]

Hi.

Since we discussed this, I've produced a cut down patch and sent it to
my wide-console users. I can confirm that it is all that is needed. I'll
be posting a new patch for Andrew shortly.

Regards,

Nigel

On Sat, 2004-01-17 at 07:41, Bill Davidsen wrote:
> Andries Brouwer wrote:
> >>>Shouldn't we be using "size_t" for unsigned int
> > 
> > 
> >>You might be right. I was just being consistent with the other definitions.
> > 
> > 
> > These are character positions on a screen.
> > When did you last see a console in text mode with a line length
> > of more than 2^31 ?
> > 
> > If you go for a minimal patch then you should replace "char"
> > in one or two places by "unsigned char" and that is all.
> 
> Are these screen positions or offsets into the string for the line? The 
> reason I ask is that with a 2-byte character set no char is going to do 
> the latter reliably, not only do people run 132 col mode with vt100 
> windows, just hitting the "full screen" button with most WM will give 
> you >127 columns.
-- 
My work on Software Suspend is graciously brought to you by
LinuxFund.org.

Attachment: signature.asc
Description: This is a digitally signed message part