Re: [NET_SCHED] BUG in qdisc TBF (token bucket filter)

[Jesper Dangaard Brouer]

(...lets keep google updated ;-))

The error have been corrected in kernel 2.4.26-rc1, by

 Dmitry Torokhov:
  o [NET_SCHED]: Fix class reporting in TBF qdisc

--Hawk

On Wed, 3 Mar 2004, Jesper Dangaard Brouer wrote:

> BUG in qdisc TBF (token bucket filter).
>
>  Problem in    : Kernel 2.4.22 (and newer, tested till 2.4.25-rc2)
>  Problem NOT in: kernel 2.4.21 (and older)
>
> Problem:
> --------
>  After I add an tbf qdisc to an htb class, then the htb class disappear
>  from the output-listing "tc -s class ls dev ethX".
>
> tc-versions:
>  I have tested with different version of the "tc" utility.
>  And different versions of the htb patch.
>
>  "tc utility, iproute2-ss010824" (debian's iproute)
>  "tc utility, iproute2-ss020116" (with htb3.6-020525)
>
> I've not tested if the tfb qdisc and htb class still works, but only
> that the output-listing is wrong.  (I'm running 2.4.21 on my
> router/firewall to be on the safe side.)
>
> Howto reproduce:
> ----------------
>  #Removing previous 'root' handle/classification
>  /sbin/tc qdisc del dev eth0 root
>  #
>  /sbin/tc qdisc add dev eth0 root handle 1: htb default 10
>  #
>  /sbin/tc class add dev eth0 parent 1: classid 1:10 htb rate 500kbit
>
>  # output-listing of class'es
>  tc -s class ls dev eth0
>  #
>  # output:
>  class htb 1:10 root prio 0 rate 500Kbit ceil 500Kbit burst 2239b cburst 2239b
>   Sent 812 bytes 6 pkts (dropped 0, overlimits 0)
>   lended: 6 borrowed: 0 giants: 0
>   tokens: 27239 ctokens: 27239
>
>  # the tbf line
>  /sbin/tc qdisc add dev eth0 parent 1:10 handle 4210: tbf rate 500kbit \
>           latency 50ms burst 2239b
>
>  # output-listing of class'es
>  tc -s class ls dev eth0
>  #
>  # output:
>  <NOTHING>
>
> The output-listing of class'es returns, if I remove the tbf qdisc again.
>
> Diff between file /net/sched/sch_tbf.c in kernel 2.4.21 and 2.4.22 is
> attached.
>
>
> Hilsen
>   Jesper Brouer
>
> --
> -------------------------------------------------------------------
> System Administrator
> Dept. of Computer Science, University of Copenhagen
> E-mail: hawk@xxxxxxx, Direct Tel.: 353 21464
> -------------------------------------------------------------------
>

Hilsen
  Jesper Brouer

--
-------------------------------------------------------------------
System Administrator / Research Assistent
Dept. of Computer Science, University of Copenhagen
E-mail: hawk@xxxxxxx, Direct Tel.: 353 21464
-------------------------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/