Re: More convenient way to grab hugepage memory
From: William Lee Irwin III
Date: Thu May 13 2004 - 02:18:23 EST
On Thu, 2004-05-13 at 16:59, William Lee Irwin III wrote:
>> Atop my other patch to nuke the unused global variables, here is a patch
>> to manually inline __do_mmap_pgoff(), removing the inline usage. Untested.
>> Are you sure you want this? #ifdef'ing out the hugetlb case is somewhat
>> more digestible with the inline in place, e.g.:
On Thu, May 13, 2004 at 05:09:01PM +1000, Benjamin Herrenschmidt wrote:
> Well, I did the breakup in 2 pieces in the first place for 2 reasons:
> - the original patch had some subtle issues with accounting
> - do_mmap_pgoff is already such a mess, let's not make it worse
> I mean, it's awful to get anything right in this function, especially
> the cleanup/exit path, which is why I think it's more maintainable
> cut in 2.
Well, writing it vaguely convinced me that it wasn't a great idea; I
suppose now that Muli can look at the result he'll be convinced likewise.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/