Re: [BUGS] [CHECKER] 99 synchronization bugs and a lock summarydatabase

From: Yichen Xie
Date: Fri Jul 02 2004 - 02:21:56 EST


> AFAICT fs/sysv/itree.c:find_shared is innocent.

I guess here's what has triggered the warning by the tool:

get_branch may try to acquire pointers_lock (itree.c:103) on one of its
paths, which was held (line 287) by find_shared...

> fs/nfsd/nfsproc.c:nfsd_proc_link is a bit obscure. There's a bug in a
> callee of nfsd_proc_link(): nfsd_link() can forget to do an fh_unlock() on
> an error path (the goto out_nfserr). Is that what the tool is referring
> to?

fh_put calls fh_unlock(fhp), which "up"s fhp->fh_dentry->d_inode->i_sem.
two calls in a row "up"s that semaphore twice, which upset the tool and
triggered the warning.

yichen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/