Re: 2.6.9-rc2-mm1

From: Jesse Barnes
Date: Fri Sep 17 2004 - 11:07:26 EST


On Thursday, September 16, 2004 11:50 pm, Len Brown wrote:
> I'm not sure exactly that the patch above was trying to fix. Looks like
> it is time to examine the latest ew7000 changes in detail. But I think
> the patch has pointed out that this routine really should be returning 0
> for success and non zero for failure; and returning dev->irq was
> probably a latent bug all along.

Right, and I'd like success to be defined a little more broadly. If dev->irq
is already valid, we should just return 0 right away. That would take care
of platforms that already have the dev in question setup properly.

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/