Re: [PATCH][OPROFILE] disable preempt when calling smp_processor_id()

From: Chris Wright
Date: Mon Nov 08 2004 - 12:23:07 EST

* John Levon (levon@xxxxxxxxxxxxxxxxx) wrote:
> On Fri, Nov 05, 2004 at 04:32:21PM -0800, Chris Wright wrote:
> > smp_processor_id() is called w/out preempt disabled. Use
> > get_cpu()/put_cpu() instead. Should this be put_cpu_no_resched()?
> No, the patch below looks fine

I realized over the weekend that it's still broken. And Cliff hit it
in some tests he ran here. The sync_buffer() function can sleep, and
while the unprotected call to smp_processor_id() is no longer a problem,
scheduling with preempt disabled is.

Linux Security Modules
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at