Re: [PATCH] VM routine fixes

From: Andrew Morton
Date: Thu Nov 11 2004 - 17:36:37 EST


dhowells@xxxxxxxxxx wrote:
>
> The attached patch fixes a number of problems in the VM routines:
>
> (1) Some inline funcs don't compile if CONFIG_MMU is not set.
>
> (2) swapper_pml4 needn't exist if CONFIG_MMU is not set.
>
> (3) __free_pages_ok() doesn't counter set_page_refs() different behaviour if
> CONFIG_MMU is not set.
>
> (4) swsusp.c invokes TLB flushing functions without including the header file
> that declares them.
>

I spy a secret, uncommented, unchangelogged hunk:

> @@ -112,7 +112,9 @@ int shmem_zero_setup(struct vm_area_stru
> if (vma->vm_file)
> fput(vma->vm_file);
> vma->vm_file = file;
> +#ifdef CONFIG_MMU
> vma->vm_ops = &generic_file_vm_ops;
> +#endif
> return 0;
> }
>

What's happening there?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/