Re: [2.6 patch] drivers/net/smc-mca.c: cleanups

[Jeff Garzik]

Adrian Bunk wrote:
> This patch contains the following cleanups:
> - make a needlessly global function static
> - make three needlessly global structs static
>
> Since after moving the now-static stucts to smc-mca.c the file smc-mca.h 
> was empty except for two #define's, I've also killed the rest of 
> smc-mca.h .

It looks like the structs should be 'static const', not just 'static'.

This comment is applicable to similar changes, also.  Use 'const' 
whenever possible.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html