Re: [PATCH] partitions/msdos.c

From: Linus Torvalds
Date: Sat Feb 26 2005 - 18:51:05 EST




On Sun, 27 Feb 2005, Andries Brouwer wrote:
>
> (Concerning the "size" version: it occurred to me that there is one
> very minor objection: For extended partitions so far the size did
> not normally play a role. Only the starting sector was significant.
> If, at some moment we decide also to check the size, then a weaker
> check, namely only checking for non-extended partitions, might be
> better at first.)

Yes. I agree - checking the size is likely _more_ dangerous and likely to
break something silly than checking the ID for zero.

So your patch it is. I'll put it in immediately after doing a 2.6.11
(no need to worry about getting into 2.6.11, since afaik the worst problem
right now is an extra partition that isn't usable).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/