Re: [PATCH 2.6.11] aoe [7/12]: support configuration of AOE_PARTITIONS from Kconfig

From: Christoph Hellwig
Date: Mon Mar 28 2005 - 12:09:33 EST


On Thu, Mar 24, 2005 at 07:21:28AM -0800, ecashin@xxxxxxxxxxxx wrote:
>
> support configuration of AOE_PARTITIONS from Kconfig
>
> Signed-off-by: Ed L. Cashin <ecashin@xxxxxxxxxx>
>
> diff -uprN a/drivers/block/Kconfig b/drivers/block/Kconfig
> --- a/drivers/block/Kconfig 2005-03-07 17:37:58.000000000 -0500
> +++ b/drivers/block/Kconfig 2005-03-10 12:19:54.000000000 -0500
> @@ -506,4 +506,19 @@ config ATA_OVER_ETH
> This driver provides Support for ATA over Ethernet block
> devices like the Coraid EtherDrive (R) Storage Blade.
>
> +config AOE_PARTITIONS
> + int "Partitions per AoE device" if ATA_OVER_ETH
> + default "16"
> + help
> + The default is to support 16 partitions per aoe device. Some
> + systems lack good support for devices with large minor
> + numbers.
> +
> + Such systems will be able to use more aoe disks when
> + AOE_PARTITIONS is set to one, but you won't be able to
> + partition the disks, and you must make sure your device
> + nodes are created to work with the value you select.
> +
> + If unsure, use 16.
> +

NACK. this changes devices nodes based on a compile-time option. Just
tell people to update their userland to a 2.6-copatible version.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/