Re: [PATCH 2.6.14-rc1-git5] sched: disable preempt in idle tasks

From: Nigel Cunningham
Date: Sun Sep 25 2005 - 18:29:31 EST


Hi.

On Thu, 2005-09-22 at 13:25, Nick Piggin wrote:
> Andrew Morton wrote:
> > Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
> >
> >>This patch should hopefully fix Nigel's bug.
> >>
> >> Split out from sched-resched-opt.patch. Tested on i386 with acpi idle
> >> and poll idle (previous iterations tested on various other architectures).
> >
> >
> > This makes the emt64 machine reboot itself, which iirc was the behaviour in
> > the failing patch from which this one was split out.
> >
> > The machine is using acpi_processor_idle().
> >
>
> OK, thanks. That must be the preempt_disable() being called in
> start_secondary(). Maybe I should have listened to the comment.
>
> Can you try the following patch?


Well, I did manage to reproduce the bug again without Nick's patches. It
seems it only occurs when I really want it to suspend because I'm going
home :). I'll apply Nick's patches now and give it some testing for a
few days.

Regards,

Nigel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/