Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT]miss-sync issues on sync mount (miss-sync on utime))

From: Machida, Hiroyuki
Date: Wed Oct 12 2005 - 05:08:22 EST

Andrew Morton wrote:
"Machida, Hiroyuki" <machida@xxxxxxxxxxxxx> wrote:

OGAWA Hirofumi wrote:

Andrew Morton <akpm@xxxxxxxx> writes:

However there's not much point in writing a brand-new function when
write_inode_now() almost does the right thing. We can share the
implementation within fs-writeback.c.

Indeed. We use the generic_osync_inode() for it?

Please let me confirm.
Using generic_osync_inode(inode, NULL, OSYNC_INODE) instaed of
sync_inode_wodata(inode) is peferable for changes on fs/open.c,
even it would write data. Is it correct?

I don't know. It depends on what you're actually trying to do, and I don't
recall anyone having described that!

I'm just little confused, because I realized generic_osync_inode(,,OSYNC_INODE)
calls sync_inode_now(), however Ogawasa-san pointed out sync_inode_now() which
my first patch used is writing data page.

Hiroyuki Machida machida@xxxxxxxxxxxxx
SSW Dept. HENC, Sony Corp.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at