Re: [PATCH 2/5] crypto/sha1.c: avoid shifting count left and right

[Herbert Xu]

On Mon, Oct 24, 2005 at 05:57:06PM +0000, Nicolas Pitre wrote:
> 
> This patch avoids shifting the count left and right needlessly for each
> call to sha1_update().  It instead can be done only once at the end in
> sha1_final().
> 
> Keeping the previous test example (sha1_update() successively called with
> len=64), a 1.3% performance increase can be observed on i386, or 0.2% on
> ARM.  The generated code is also smaller on ARM.

Patch applied.

So in summary, patch 1 has been applied with some additional changes.
Patch 2 is applied as is except for a change to accomodate the cpu->be
change from Denis.

Patches 3-5 have been made redundant by the cpu->be change.

Thanks again for your efforts in making sha1 smaller and faster.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/