Re: [PATCH] Remove gfp argument from kstrdup()

[Timo Hirvonen]

On Fri, 6 Jan 2006 13:51:41 +0200
Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:

> On 1/5/06, Timo Hirvonen <tihirvon@xxxxxxxxx> wrote:
> > All kstrdup() callers use GFP_KERNEL flag so this parameter seems to be
> > useless.
> 
> Please don't. You're making the API inconsistent and forcing everyone
> to use GFP_KERNEL for little or no benefit.

I don't see why any other GFP_* flag could be useful for strings.

-- 
http://onion.dynserv.net/~timo/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/