Re: [PATCH] Remove gfp argument from kstrdup()

[Arjan van de Ven]

On Fri, 2006-01-06 at 14:15 +0200, Timo Hirvonen wrote:
> On Fri, 6 Jan 2006 13:51:41 +0200
> Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> 
> > On 1/5/06, Timo Hirvonen <tihirvon@xxxxxxxxx> wrote:
> > > All kstrdup() callers use GFP_KERNEL flag so this parameter seems to be
> > > useless.
> > 
> > Please don't. You're making the API inconsistent and forcing everyone
> > to use GFP_KERNEL for little or no benefit.
> 
> I don't see why any other GFP_* flag could be useful for strings.

I think you missed the point a bit..
the GFP_ flags aren't so much about what you allocate it, but in what
circumstances you are allocating (eg inside a lock/irq or not etc)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/