Re: [PATCH] x86_64 built-in command line

[H. Peter Anvin]

Andi Kleen wrote:
>   
> > +#ifdef CONFIG_CMDLINE_BOOL
> > +	strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> > +#endif
>
> I think I would prefer a strcat.
>
> Also you should describe the exact behaviour (override/append) in Kconfig help.

In the i386 thread, Matt described having a firmware bootloader which 
passes bogus parameters.  For that case, it would make sense to have a 
non-default CONFIG option to have override rather than conjoined (and I 
maintain that the built-in command line should be prepended.)

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/