Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h

From: Pavel Machek
Date: Sun Aug 06 2006 - 18:00:14 EST


> > We have BUG_ON() right for this, don't we?
> Well yes, but there are over a thousand BUG->BUG_ON conversion
> possibilities in the tree. If people start sending them three-at-a-time
> we'll all go mad.
> So. If we're going to do this, bigger patches, please.

If we are going that way... I guess we should specify if BUG_ON() has
to evaluate its arguments even if it is compiled out...

Or probably better pecify that BUG_ON() must not have side effects?

Thanks for all the (sleeping) penguins.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at