Re: [PATCH] move IMMUTABLE|APPEND checks to notify_change()

From: Kirill Korotaev
Date: Wed Aug 09 2006 - 05:03:38 EST


[PATCH] move IMMUTABLE|APPEND checks to notify_change()

This patch moves lots of IMMUTABLE and APPEND flag checks
scattered all around to more logical place in notify_change().

NAK. For example, you are allowed to do unames(file, NULL) on
any file you own or can write to, whether it's append-only or
not. With your change that gets -EPERM.

Al, will you ACK the patch allowing to set current times in notify_change() for
APPEND files?

However, I'd like to see an explanation on dim@'s question why semantics
are different and current time is allowed to be set, while arbitrary time is not.

Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/