Re: [PATCH] move IMMUTABLE|APPEND checks to notify_change()

From: Kirill Korotaev
Date: Wed Aug 09 2006 - 06:07:35 EST

Al Viro wrote:
On Tue, Aug 08, 2006 at 03:44:07PM +0400, Kirill Korotaev wrote:

[PATCH] move IMMUTABLE|APPEND checks to notify_change()

This patch moves lots of IMMUTABLE and APPEND flag checks
scattered all around to more logical place in notify_change().

NAK. For example, you are allowed to do unames(file, NULL) on
any file you own or can write to, whether it's append-only or
not. With your change that gets -EPERM.

Does such check in notify_change() looks better for you?

if (IS_IMMUTABLE(inode))
return -EPERM;
if (IS_APPEND(inode) &&
return -EPERM;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at