On Sat, 2006-12-09 at 00:05 +0100, Thomas HellstrÃm wrote:Arjan,
On Fri, 2006-12-08 at 19:24 +0100, Thomas HellstrÃÂm wrote:I understand your feelings about this, and as you probably understand, the
+ }this bit is more or less evil as well...
+
+ if (alloc_size <= PAGE_SIZE) {
+ new->memory = kmalloc(alloc_size, GFP_KERNEL);
+ }
+ if (new->memory == NULL) {
+ new->memory = vmalloc(alloc_size);
1) vmalloc is expensive all the way, higher tlb use etc etc
2) mixing allocation types is just a recipe for disaster
3) if this isn't a frequent operation, kmalloc is fine upto at least 2
pages; I doubt you'll ever want more
kfree / vfree thingy is a result of the above allocation scheme.
the kfree/vfree thing at MINIMUM should be changed though. Even if you
need both kfree and vfree, you should key it off of a flag that you
store, not off the address of the memory, that's just unportable and
highly fragile. You *know* which allocator you used, so store it and use
THAT info.
The allocated memory holds an array of struct page pointers. The number of
struct page pointers will range from 1 to about 8192, so the alloc size
will range from 4bytes to 64K, but could go higher depending on
architecture.
hmm 64Kb is a bit much indeed. You can't do an array of upto 16 entries
with one page in each array entry?