Re: [patch] change WARN_ON back to "BUG: at ..."
From: Ingo Molnar
Date: Thu Dec 28 2006 - 04:19:19 EST
* Pavel Machek <pavel@xxxxxx> wrote:
> > But lots of people have now written downstream log-parsing tools
> > which might break due to this change, so I'm inclined to go with
> > Ingo's patch, and restore the old (il)logic.
> People should not be parsing syslog. If they do, they deserve
> occassional breakage.
so what other method do you propose to those who are working on
increasing the reliability of the kernel by running automatic regression
tests and boot allyesconfig kernels, to figure out whether out of the
tons of kernel logs there was any problem? Right now "^BUG: " is a
pretty universal filter, and i dont see a problem in preserving that.
(for lockdep there's a 'debug_locks' line in /proc/lockdep_stats that
tells us whether any lock related assert was printed by the kernel, and
my scripts monitor that. Along that line we could introduce a
/proc/sys/kernel/bugs counter for tools to monitor. But even after that,
you have to find the place in the syslog so having a text signature for
kernel bugs is still a good idea.)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/