Re: [PATCH] scsi_lib.c: continue after MEDIUM_ERROR

[Mark Lord]

James Bottomley wrote:
> First off, please send SCSI patches to the SCSI list:
> <linux-scsi@xxxxxxxxxxxxxxx>

Fixed already, thanks!

> > This patch fixes the behaviour to be similar to what we had originally.
> >
> > When a bad sector is encounted, SCSI will now work around it again,
> > failing *only* the bad sector itself.
>
> Erm, but the corollary is that if we get a large read failure because of
> a bad track, you're going to try and chunk up it a sector at a time

That's better than the huge data-loss scenario that we currently
have for single-sector errors.  MUCH better.

> forcing an individual error for each sector is going to annoy some
> people ... particularly removable medium ones which return this error if
> the medium isn't present ... Are you sure this is really what we want to
> do?

No, for removed-medium everything just fails right away.
This patch is *only* for media errors, not any other failures.

Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/