Re: [PATCH 1/5] Use wake_up_locked() in eventpoll

From: Matthew Wilcox
Date: Fri Oct 19 2007 - 12:29:17 EST


On Thu, Oct 18, 2007 at 08:56:23PM -0700, Arjan van de Ven wrote:
> Have you tested this patch with LOCKDEP enabled? eventpoll is... tricky
> in what it does with waitqueues and locks.... and some of this stuff is
> there, afaik, to deal with that. You're now changing this ... call me
> chicken :)

I haven't tested it, but it's a simple textual substitution:

#define wake_up_locked(x) __wake_up_locked((x),
TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE)

so it should be identical in effect.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/