Re: [PATCH] Mark early_printk as asmlinkage

[Pavel Machek]

On Wed 2008-03-12 15:04:43, H. Peter Anvin wrote:
> Jiri Slaby wrote:
> >It's not explicitly marked as asmlinkage, but invoked 
> >from x86_32
> >startup code with parameters on stack.
> >
> >No other architectures define early_printk and none of 
> >them are affected
> >by this change, since defines asmlinkage as empty token.
> 
> NAK.
> 
> The regparm ABI for x86-32 uses parameters on the stack 
> when the function is varadic (as it is here), so this is 
> unnecessary.

I'd call asmlinkage kind of documentation, then. Not everyone is as
good with x86 abi as you are...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/