Re: [PATCH] Mark early_printk as asmlinkage

[H. Peter Anvin]

Pavel Machek wrote:
> On Wed 2008-03-12 15:04:43, H. Peter Anvin wrote:
> > Jiri Slaby wrote:
> > > It's not explicitly marked as asmlinkage, but invoked 
> > >from x86_32
> > > startup code with parameters on stack.
> > >
> > > No other architectures define early_printk and none of 
> > > them are affected
> > > by this change, since defines asmlinkage as empty token.
> > NAK.
> >
> > The regparm ABI for x86-32 uses parameters on the stack 
> > when the function is varadic (as it is here), so this is 
> > unnecessary.
>
> I'd call asmlinkage kind of documentation, then. Not everyone is as
> good with x86 abi as you are...

Since it's already only used on x86-32 and we no longer support 
non-regparm x86, I'd like to at least get to the point where x86-32 
doesn't have any function.  We can retain it for documentation's sake, 
but even then it's iffy... is "this is callable from assembly" really 
something arch-invariant.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/