Re: [PATCH 2/6] compcache: block device - internal defs

[Mariusz Kozlowski]

Hi Nitin,

>  +#define K(x)   ((x) >> 10)
>  +#define KB(x)  ((x) << 10)

Hm. These look cryptic unless you remember what they do.
Could have better names?

> +#define CC_DEBUG2((fmt,arg...) \
> +       printk(KERN_DEBUG C fmt,##arg)

Unbalanced parenthesis.

Just my 0.05zl.

	Mariusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/