Re: [PATCH 1/3] mmc: Export internal host state through debugfs

[Haavard Skinnemoen]

Pierre Ossman <drzeus-mmc@xxxxxxxxx> wrote:
> > Hmm. You mean it's better with three #ifdefs than one?
> >   
> 
> Fewer lines though. Those dummy function stick out like a sore thumb.
> It's a decent trade-off when you have multiple callers, but here we have
> just the one.

Actually, if debugfs is disabled, debugfs_create_dir() and friends are
inline functions which return ERR_PTR(-ENODEV). So if we just remove
the whole #ifdef altogether, gcc should be smart enough to optimize
away the whole thing if debugfs isn't enabled...

I'll give it a try.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/