Re: [PATCH] USB: fix interrupt disabling for HCDs with sharedinterrupt handlers

From: Alan Stern
Date: Mon Jun 30 2008 - 15:35:40 EST


On Mon, 30 Jun 2008, Stefan Becker wrote:

> Hi,
>
> here is the proposed patch to fix the problem. I hope I used git
> correctly to generate it...

> This patch doesn't modify the interface of usb_add_hcd(), i.e. HCD code
> can still use IRQF_DISABLED. It will now silently convert this into an
> internal HCD flag and clear IRQF_DISABLED before requesting the interrupt
> from the Linux core. usb_hcd_irq() will check this flag to disable/re-enable
> the interrupts on a case by case basis.

Don't bother with this extra stuff. All USB host controller drivers
want to have interrupts disabled when their IRQ handlers run.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/