Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

From: Segher Boessenkool
Date: Thu Jul 17 2008 - 01:59:45 EST

diff --git a/Documentation/powerpc/dts-bindings/gpio/led.txt b/Documentation/powerpc/dts-bindings/gpio/led.txt
new file mode 100644
index 0000000..7e9ce81
--- /dev/null
+++ b/Documentation/powerpc/dts-bindings/gpio/led.txt
@@ -0,0 +1,15 @@
+LED connected to GPIO
+Required properties:
+- compatible : should be "gpio-led".

This "compatible" name is a bit too generic. No, I don't know a
better name :-(

+- label : (optional) the label for this LED. If omitted, the label is
+ taken from the node name (excluding the unit address).

What is a label? It should be described here. Also, its encoding
should be described ("a string" I guess).

+- gpios : should specify LED GPIO.
+led@0 {
+ compatible = "gpio-led";
+ label = "hdd";
+ gpios = <&mcu_pio 0 0>;

You show a unit address but have no "reg" value. This is

What would be the parent node of this, btw?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at